This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Need new strings to handle overdue payments #7524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
reviewed
Mar 10, 2017
| @@ -198,7 +200,7 @@ ledgerRecoveryFailedTitle=Recovery Failed | |||
| ledgerRecoveryFailedMessage=Please re-enter keys or try different keys. | |||
| ledgerRecoveryNetworkFailedTitle=Network Error | |||
| ledgerRecoveryNetworkFailedMessage=Please check your internet connection and try again. | |||
| ledgerRecoveryContent=The balance of the recovered wallet will be transferred to your new Brave wallet. The old wallet will still exist as an empty wallet. | |||
| ledgerRecoveryContent=Your previous wallet will now be used. Your new wallet will be discarded. | |||
There was a problem hiding this comment.
Just to confirm:
@mrose17 when you do a restore, it'll use the previous wallet (what you just restored), right? So the old text here (about transferring the balance to your new wallet) was wrong?
There was a problem hiding this comment.
correct. wallet recovery is now actually "recovery of old wallet" rather than "transfer the balance of the old wallet to the new wallet"
|
Regarding payment history button I think this is not relevant any more, because we removed payment history button and added only the icon, more in #7532 |
|
@NejcZdovc I believe the strings are also shown when you click the icon (and it shows the statements) Although, if that new icon isn't clickable then the strings may not be needed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7078
git rebase -ito squash commits (if needed).Test Plan:
reconcileStampledger-state.jsonto the current timestamp or more than a day in the past.