This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 971
Menu on Windows now properly responds to ALT #7485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menu is now toggled only under these conditions: - the left ALT key is pressed (ignore AltGr) - last key pressed was ALT (typing ALT codes should not toggle menu) - no other key is being pushed simultaneously - since initial keydown, ALT has been the only key pressed NOTE: key state is reset when window blurs (in case you used a shortcut that opened a new window, which prevents the keyup handler from firing on release) Auditors: @jonathansampson, @bbondy Fixes #5775
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My numpad is wireless, and stopped working. But what I could test worked as expected, and the commit is pretty straight-forward.
@srirambv would you be able to try this out too before we merge? |
|
quick update- @srirambv and I had tested in person after he plugged in an external keyboard which has the number pad
I also updated the text of the original post here to make it clear what functionality worked prior to this PR (meaning we are testing it for regression) |
Given the above, I'll go ahead and merge this one 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
Make sure "Hide menu bar by default" is set to true in Preferences > General
Alt codes (ensure behavior has not regressed)
duckduckgo.com
AltGr (ensure behavior has not regressed)
Multiple keys at the same time
Happy path
Description
Menu on Windows now properly responds to ALT
Menu is now toggled only under these conditions:
NOTE: key state is reset when window blurs (in case you used a shortcut that opened a new window, which prevents the keyup handler from firing on release)
Auditors: @jonathansampson, @bbondy
Fixes #5775
git rebase -i
to squash commits (if needed).