This repository was archived by the owner on Dec 11, 2019. It is now read-only.
fix "Cannot read property 'size' of undefined" error when getting persistent state #7467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
approved these changes
Mar 3, 2017
…sistent state When upgrading from 0.13.4 to 0.13.5, this was causing getting persistent state to fail on startup, thereby losing session state. Fix #7466 Test Plan: 1. copy your session-store-1 from Brave 0.13.4 into the brave-development profile folder 2. npm start 3. Brave should show tabs, bookmarks, settings, etc from the 0.13.4 profile
diracdeltas
commented
Mar 3, 2017
| @@ -483,6 +483,10 @@ describe('tabState unit tests', function () { | |||
| const expectedAppState = defaultAppState.set('tabs', tabsWithoutField) | |||
| assert.deepEqual(newAppState, expectedAppState) | |||
| }) | |||
| it('returns the state (unchanged) if tabs is falsey', function () { | |||
| const newAppState = tabState.removeTabField(defaultAppState, 'loginRequiredDetail') | |||
There was a problem hiding this comment.
seems that you would want defaultAppState without the tabs field for this test?
There was a problem hiding this comment.
Fixed- that variable exists in other files (with other states- whoops!). Thanks for catching 😄
Auditors: @diracdeltas Test Plan: `npm run unittest -- --grep='returns the state \(unchanged\) if tabs is falsey'`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
run
npm run unittest -- --grep='returns the state \(unchanged\) if tabs is falsey'Description
When upgrading from 0.13.4 to 0.13.5, this was causing getting persistent state
to fail on startup, thereby losing session state. Fix #7466
Test Plan:
git rebase -ito squash commits (if needed).