Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

make urlbar borderRadius match addFunds toggle #7455

Merged
merged 1 commit into from
Mar 2, 2017
Merged

make urlbar borderRadius match addFunds toggle #7455

merged 1 commit into from
Mar 2, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Mar 2, 2017

Auditors: @bbondy, @bsclifton

Fix #7449
Fix #7447

Test Plan (for #7449):

Go to a valid publisher url (i.e. brianbondy.com)

  • urlbar shouldn't have right borderRadius

Exclude that publisher

  • urlbar should have right borderRadius

Disable payments

  • urlbar should have right borderRadius

Go to an about page or other pages that shouldn't have publisherToggle (protocols other than HTTP)

  • urlbar should have right borderRadius

This also addressed #7447

Test plan (for #7447)

  • Clear session-store and ledger-synopsis file
  • Enable payments, wait till the payments menu is opened
  • Open a new tab by clicking on the + button
  • New tab should open immediately
  • URL bar should be accessible

@cezaraugusto cezaraugusto added this to the 0.13.5 milestone Mar 2, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 2, 2017
@cezaraugusto cezaraugusto requested review from bbondy and bsclifton March 2, 2017 16:45
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Windows- looks great 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants