Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Split and refactor LedgerTable component #7408

Merged
merged 1 commit into from
Mar 3, 2017
Merged

Split and refactor LedgerTable component #7408

merged 1 commit into from
Mar 3, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Feb 27, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Close #7379

Auditors: @bsclifton, @luixxiul

This PR addressed:

  • Cleanup of preferences.js
  • component refactor to Aphrodite
  • make use of Flexbox whenever possible
  • minor touch-ups regarding code indentation/readability
  • Note: ledgerTable (where publishers are shown) was kept as-is since it uses sortableTable component, which refactor should be addressed in another issue (update: ledgerTable included)

Test Plan

  • Ledger functionality should be kept the same:
    • Show only included sites should toggle between enabled/disabled publishers
    • Permanently remove a site should remove its row
    • Table should be kept sortable (untouched code)
    • Include toggle should be kept toggling enabled/disabled state

screen shot 2017-02-27 at 4 57 02 pm

Note that verified state are fake and were hardcoded for preview purposes

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me... however, unit tests fail. Now that we use Aphrodite, we need to put mocks in place for the SVG in tests which end up rendering this component

You can see which ones fail with npm run unittest

@cezaraugusto
Copy link
Contributor Author

sorry I skip that. Updated

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄 thanks for updating the tests

@bsclifton bsclifton merged commit d2a6556 into brave:master Mar 3, 2017
@cezaraugusto cezaraugusto deleted the refactor/7379 branch July 25, 2017 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants