Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix regression of about:styles #7387

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Fix regression of about:styles #7387

merged 1 commit into from
Feb 27, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 25, 2017 •
edited by bsclifton
Loading

Test Plan

make sure about:styles is as it should be

Original issue description

Fixes #7201

including

  • aphrodite/no-important

Auditors:

Test Plan:

  1. Open about:styles
  2. Make sure the code snippets of TextArea and DefaultTextArea are no longer unstyled
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Fix regression of about:styles
bb34137 
Fixes #7201

including
- aphrodite/no-important

Auditors:

Test Plan:
1. Open about:styles
2. Make sure the code snippets of TextArea and DefaultTextArea are no longer unstyled
@luixxiul luixxiul self-assigned this Feb 25, 2017
cezaraugusto
cezaraugusto approved these changes Feb 27, 2017
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

bsclifton
bsclifton approved these changes Feb 27, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small button issue aside (since that would be fixed with a different issue / PR), this looks good 👍

@bsclifton bsclifton merged commit c0d1f84 into brave:master Feb 27, 2017
@bsclifton bsclifton added this to the 0.13.5 milestone Feb 27, 2017
@luixxiul luixxiul deleted the aboutStyles-aphrodite branch February 28, 2017 01:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@bsclifton bsclifton bsclifton approved these changes

Assignees

@luixxiul luixxiul

Labels
QA/test-plan-specified refactoring/aphrodite
Projects
None yet
Milestone
0.13.5
Development

Successfully merging this pull request may close these issues.
3 participants
@luixxiul @cezaraugusto @bsclifton