Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Remove unnecessary separator from browser's Help menu. #7228

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Remove unnecessary separator from browser's Help menu. #7228

merged 1 commit into from
Feb 16, 2017

Conversation

siemiatj
Copy link
Contributor

Seems that additional separator that was left in the menu code slips through because there's a Search component added to the menu dropdown. So I just removed it since I don't think we can fix it here.

Fixes #7109

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@siemiatj siemiatj changed the title Remove unnecessary separator from browser's Help manu. Remove unnecessary separator from browser's Help menu. Feb 13, 2017
@bbondy
Copy link
Member

bbondy commented Feb 16, 2017

good idea to just remove, thanks.

@bbondy bbondy merged commit 55395b9 into brave:master Feb 16, 2017
@bbondy bbondy added this to the 0.13.5 milestone Feb 16, 2017
mrose17 added a commit that referenced this pull request Feb 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sanitizeTemplateItems should remove first item if it is a separator
4 participants