This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Create Plugins preference page #7157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#7155 was merged; can you rebase @cezaraugusto? Also, I moved this to 0.13.4 😄 |
|
thanks, rebased |
bsclifton
suggested changes
Feb 13, 2017
There was a problem hiding this comment.
Great work! This is nice and clean 😄
I verified that going to netflix.com pops up the Widevine CDM as expected and everything works. With regards to Flash though, you missed a spot which links back to preferences (these should be updated to the new about:preferences#plugins route)
|
done, thanks! |
Auditors: @bbondy, @bsclifton Fix #7101
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
Details
git rebase -ito squash commits (if needed).Fixes #7101