Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update wording for preferences > brave starts with > Dashboard #6824

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Update wording for preferences > brave starts with > Dashboard #6824

merged 1 commit into from
Jan 23, 2017

Conversation

bsclifton
Copy link
Member

Now says "a new tab"

Fixes #6521

I created #6823 to address the core issue (so that users with newtab => blank can access the tabs).

Auditors: @bradleyrichter, @luixxiul

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan

  1. Go to about:preferences
  2. Ensure "Brave starts with" dropdown no longer has "Dashboard"; it should have "a new tab"

…ays "a new tab"

Fixes #6521

I created #6823 to address the core issue (so that users with newtab => blank can access the tabs.

Auditors: @bradleyrichter, @luixxiul
@bsclifton bsclifton added this to the 0.13.0 milestone Jan 23, 2017
@bsclifton bsclifton self-assigned this Jan 23, 2017
@bsclifton bsclifton merged commit f9625f7 into brave:master Jan 23, 2017
@bsclifton bsclifton deleted the fix-wording-preferences-newtab branch January 23, 2017 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants