Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed the regression of unclickable buttons under #navigator #6681

Merged
merged 1 commit into from
Jan 16, 2017
Merged

Fixed the regression of unclickable buttons under #navigator #6681

merged 1 commit into from
Jan 16, 2017

Conversation

luixxiul
Copy link
Contributor

This fixes the regression I unintentionally introduced with 19360c1#diff-02c4b23ad267fe636760179e32fa29ceR842 for #6035

Fixes #6680
Closes #6253

Auditors: @bsclifton

Test Plan:

  1. Make sure every button on the navigation bar is clickable
  2. Open https://jsfiddle.net/
  3. Block scripts from the top right lion icon
  4. Make sure the noScript button on the navigation bar is clickable
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixed the regression of unclickable buttons under #navigator
2a78248 
This fixes the regression I unintentionally introduced with 19360c1#diff-02c4b23ad267fe636760179e32fa29ceR842 for #6035

Fixes #6680
Closes #6253

Auditors: @bsclifton

Test Plan:
1. Make sure every button on the navigation bar is clickable
2. Open https://jsfiddle.net/
3. Block scripts from the top right lion icon
4. Make sure the noScript button on the navigation bar is clickable
@luixxiul luixxiul added this to the 0.13.0 milestone Jan 16, 2017
luixxiul referenced this pull request Jan 16, 2017
@bsclifton
Regression appears to have reset the webkit drag attribute on navigat…
ef4bb2f 
…ion buttons. This is especially important for Windows, because its BrowserWindow is using the FramelessWindow.

Fixes #6253

Auditors: @bbondy, @luixxiul
@bbondy
Copy link
Member

bbondy commented Jan 16, 2017

Tested this on win10 and it's working well. Tested on master and could reproduce the problem first.

@bbondy bbondy merged commit d3b0b25 into brave:master Jan 16, 2017
@bsclifton
Copy link
Member

Awesome, thanks @bbondy 😄 ++

@luixxiul luixxiul deleted the fix-navigationBar-regression branch January 17, 2017 01:44
This was referenced Jan 17, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/navbar misc/button regression
Projects
None yet
Milestone
0.13.0
3 participants
@luixxiul @bbondy @bsclifton