Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Change verb tense of paymentHistoryFooter to past tense #6628

Closed
wants to merge 1 commit into from

Conversation

bkilrain
Copy link
Contributor

@bkilrain bkilrain commented Jan 13, 2017

This commit changes the paymentHistoryFooter text to match the fact that
reconcileDate will always be in the past (it is generated from moment.js's
fromNow() method
).

Fixes #6059

Auditors: @bsclifton

Tests: n/a

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan: n/a

This commit changes the paymentHistoryFooter text to match the fact that
reconcileDate will always be in the past (it is generated from moment.js's
fromNow() method).

Fixes brave#6059

Auditors: @bsclifton

Tests: n/a
@bkilrain
Copy link
Contributor Author

by the way - I suspect my git workflow is lacking. If you have a tip, please let me know :)

@luixxiul
Copy link
Contributor

@bkilrain I'm sorry but @mrose17 got another way to fix the issue, so let me close this.

If you are interested, please have a look at the contributors backlog for more tasks :-)

https://github.com/brave/browser-laptop/milestone/47

Thanks for your understanding.

@luixxiul luixxiul closed this Jan 20, 2017
@bsclifton
Copy link
Member

@bkilrain sorry I didn't get to this sooner- we've had an unusually large backlog of items recently. The good news is our major blockers have been resolved and we're starting to work through all the PRs 😄

Please hit me up any time if you have questions. You're welcome to join our Slack too (shoot me a message at clifton@brave.com if you're interested) 😄

@bkilrain
Copy link
Contributor Author

All good~ I'll check out the backlog 👍

@mrose17
Copy link
Member

mrose17 commented Jan 20, 2017

many thanks!

@bkilrain bkilrain deleted the paymentHist branch January 25, 2017 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants