This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Fix SYNC_CLEAR_HISTORY #6625
Merged
Fix SYNC_CLEAR_HISTORY #6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d17010 to
cddf093
Compare
diracdeltas
reviewed
Jan 13, 2017
| syncConstants.SYNC_ADD_SITE_SETTING, | ||
| syncConstants.SYNC_UPDATE_SITE_SETTING, | ||
| syncConstants.SYNC_REMOVE_SITE_SETTING | ||
| ] |
There was a problem hiding this comment.
it would be slightly easier for this to be SYNC_ACTIONS_WITHOUT_ITEMS since most actions in the future will probably have items
There was a problem hiding this comment.
i think these constants should go inside validateAction since they are only used in there
diracdeltas
approved these changes
Jan 13, 2017
cddf093 to
4ef2256
Compare
|
No new failed tests. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing history wasn't clearing SyncRecord historySites.
This happened because
app/sync.jsdoAction()always checks ifaction.itemis a proper Sync item.This PR resolves it by checking for action.item only when the action requires it.
Test Plan:
Deleting category: HISTORY_SITESAuditors: @diracdeltas