Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Create react test for audio icon #6460

Merged
merged 1 commit into from
Dec 30, 2016
Merged

Create react test for audio icon #6460

merged 1 commit into from
Dec 30, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Dec 30, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #6307

Auditors @bbondy @bsclifton

These are my first React unittests. Can you all tell me how they are looking / what I'm missing?

@bsclifton bsclifton removed this from the 0.13.1 milestone Dec 30, 2016
@bsclifton
Copy link
Member

Looks (and works) great! 😄 Awesome job

cc: @cezaraugusto since this is a much easier to digest example than the DownloadItem (as far as faking clicks goes)

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit cf1b06f into master Dec 30, 2016
@bsclifton bsclifton deleted the audio-icon-tests branch December 30, 2016 21:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants