This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Fix broken array concat behavior during app relaunch #6368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20d24e9 to
c2468b9
Compare
|
++ |
bbondy
reviewed
Dec 21, 2016
| @@ -359,7 +359,6 @@ const setVersionInformation = (data) => { | |||
| {name: 'os.platform', version: os.platform()}, | |||
| {name: 'os.release', version: os.release()}, | |||
| {name: 'os.arch', version: os.arch()} | |||
| // TODO(bsclifton): read the latest commit hash from a file, etc. | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The + turns it from an array into a string on Windows (new node behavior?). Definitely wrong.
This fix is to help with #5938. Tested on Mac and Windows. Please note: it doesn't fix the issue, but it does correct the wrong behavior
Fixes #6369
Auditors: @bbondy, @bridiver