-
Notifications
You must be signed in to change notification settings - Fork 971
Change CSP img-src directive on about:extensions #6290
Conversation
@diracdeltas @bridiver did this change recently? I'm wondering why this would of started happening. |
this actually doesn't look correct to me. An extension shouldn't be loading images from file urls |
@@ -141,7 +141,7 @@ let generateBraveManifest = () => { | |||
'form-action': '\'none\'', | |||
'referrer': 'no-referrer', | |||
'style-src': '\'self\' \'unsafe-inline\'', | |||
'img-src': '* data:', | |||
'img-src': '\'self\' file://*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you need to keep '*' and 'data:', otherwise favicons won't load in about:preferences ledger panel
in 0.12.5 i see the pdfjs extension loaded from |
where do you see that @diracdeltas? It should be loading images using chrome-extension urls, not file urls |
@bridiver about:extensions |
I think they should be using chrome extension urls |
I'm going to close this in favour of loading the image from the extension itself instead. I'll do a different push for it. |
Fix #6257
Auditors: @bbondy
git rebase -i
to squash commits (if needed).Test Plan: