Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Telemetry #6267

Merged
merged 4 commits into from
Jan 14, 2017
Merged

Telemetry #6267

merged 4 commits into from
Jan 14, 2017

Conversation

aekeus
Copy link
Member

@aekeus aekeus commented Dec 16, 2016

This pull request adds telemetry calls to the browser for C.I. measurement.

Testing will require the provisioning of a vault-collector instance and a number of configuration steps outlined in docs/telemetry.md

@aekeus aekeus added this to the 0.13.1 milestone Dec 16, 2016
@aekeus aekeus self-assigned this Dec 16, 2016
@posix4e
Copy link
Contributor

posix4e commented Dec 21, 2016

You must resolve conflicts

@aekeus
Copy link
Member Author

aekeus commented Dec 21, 2016

Thanks @posix4e. Will resolve before 0.13.1 merge date.

@aekeus
Copy link
Member Author

aekeus commented Dec 23, 2016

Conflicts resolved

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using steps outlined; @aekeus confirmed that the data made it's way over 😄

@bsclifton
Copy link
Member

bsclifton commented Jan 13, 2017

Running into trouble running the following test:
npm run test -- --grep="Clear Browsing Panel with saved state values saves the history switch state"

it's throwing the following error:

1) Clear Browsing Panel with saved state values saves the history switch state:
     Promise was rejected with the following reason: Error: unknown error: Cannot read property 'appStoreRenderer' of undefined

I checked the 0.13.1-branch and the test fails there too. I've been testing as I've been accepting and merging; I wonder if one of the merges had a conflict which ended up breaking this (maybe when it auto-resolved)?

@bsclifton
Copy link
Member

OK revisited this and turns out the problem was me 😄 I was running npm run watch not npm run watch-test. I reran the tests which failed in the CI build and all of them passed 😄 Merging!

@bsclifton bsclifton merged commit 4abf18d into 0.13.1-branch Jan 14, 2017
@bsclifton bsclifton deleted the telemetry branch January 14, 2017 06:43
@bsclifton
Copy link
Member

@aekeus is there an associated issue for this?

@aekeus
Copy link
Member Author

aekeus commented Jan 16, 2017

Yes, implements #6265

@srirambv srirambv mentioned this pull request Feb 3, 2017
86 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants