Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix webtorrent, don't exclude dependencies #5921

Merged
merged 2 commits into from
Nov 30, 2016
Merged

Conversation

dcposch
Copy link
Contributor

@dcposch dcposch commented Nov 29, 2016

Fixes #5849

Also lazy-load webtorrent-remote in the browser process.

BTW, I recommend:

  • Measuring startup time. This can be as simple as adding a console.time ... console.timeEnd. We do that in WebTorrent Desktop and it helps catch performance regressions.
  • Add a bit more error handling on startup. If the packaged app crashes on launch because of a require() error, it would be better to print the stacktrace than the LSOpenURLsWithRole exception.

@dcposch
Copy link
Contributor Author

dcposch commented Nov 29, 2016

@feross @bbondy @luixxiul

@bbondy bbondy added this to the 0.13.0 milestone Nov 30, 2016
@bbondy
Copy link
Member

bbondy commented Nov 30, 2016

++

@bbondy bbondy merged commit 558e322 into brave:master Nov 30, 2016
@luixxiul
Copy link
Contributor

Should this fix #5855 too? @dcposch

@dcposch
Copy link
Contributor Author

dcposch commented Nov 30, 2016

@luixxiul yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants