This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix webtorrent, don't exclude dependencies #5921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5849
Also lazy-load
webtorrent-remote
in the browser process.require('webtorrent-remote/server')
will pull inwebtorrent
, which is a big module.BTW, I recommend:
console.time
...console.timeEnd
. We do that in WebTorrent Desktop and it helps catch performance regressions.require()
error, it would be better to print the stacktrace than theLSOpenURLsWithRole
exception.