Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Import browser data switches misaligned #5863

Merged
merged 1 commit into from
Nov 28, 2016
Merged

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Nov 28, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #5860

Auditors @bsclifton @darkdh @bradleyrichter

Tiny change like @bradleyrichter recommended but I think it looks a bit more obvious. I'm fine to scrap it if you disagree!

Test Plan:

  1. Open Brave
  2. Go to Preferences
  3. Click "Import now..."
  4. See that the nested switch for merge favorites is pushed to the right.

Old:
screen shot 2016-11-27 at 5 31 24 pm

New:
screen shot 2016-11-27 at 5 28 59 pm

@bradleyrichter
Copy link
Contributor

5 more and it should be GTG for now. Thanks @jkup !

@darkdh
Copy link
Member

darkdh commented Nov 28, 2016

++

@darkdh darkdh merged commit 1755151 into master Nov 28, 2016
@bsclifton bsclifton deleted the browser-import-switches branch November 28, 2016 07:37
@bsclifton
Copy link
Member

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/importer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants