This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Prevent duplicate separators for all context menu items. #5846
+169
−99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).This update will ensure we will never have double separators going forward on Windows or Linux.
Fixes #5765
Auditor: @bbondy, @cezaraugusto
Includes these changes:
sanitizeTemplateItems
method to filter out bad entriesmenuUtil
fromapp/browser
=>app/common
test/unit/app
, instead oftest/unit/lib
)menuUtil
and items incontextMenu.js
to reinforce distinction between template items and electron menu items (the compiled template)Test plan