This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Fixes #4398
Fixes #1594
Auditors: @lucidNTR, @cezaraugusto, @jkup
This PR was originally by @lucidNTR; I adjusted a few things and then also added right click as a way to trigger the long press button. I went ahead and added webdriver tests for this functionality too.
screenshot
Here's what the new menu looks like (you can click and hold on the + or right click it)
![screen shot 2016-11-16 at 4 31 20 pm](https://cloud.githubusercontent.com/assets/4733304/20370151/5f1d3bb2-ac1a-11e6-858d-cc756f698148.png)
Because the right-click change was made to the LongPressButton control, the back and forward buttons get this change for free (they were already triggerable by click and hold):
![screen shot 2016-11-16 at 4 31 42 pm](https://cloud.githubusercontent.com/assets/4733304/20370171/7f0dfeca-ac1a-11e6-85e7-ebdb59c52de1.png)
test plan