Add new "empty new tab" option in preferences (for what new tab does)

[bsclifton]

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).

includes tests 😄

Fixes #5682

Please note: choosing this option does NOT put focus in the URL bar. Is this OK?
cc: @diracdeltas

Auditors: @bradleyrichter, @bbondy

Test Plan:

1. Launch Brave and go to preferences
2. Change "A new tab shows" to "empty new tab"
3. Open a new tab; notice it's about:blank

[bradleyrichter]

@bsclifton I'll pull this in and edit the strings and commit those.

[bsclifton]

Working with @bradleyrichter on this one... not ready to be accepted yet

[bradleyrichter]

current proposal:

[bbondy]

Please note: choosing this option does NOT put focus in the URL bar. Is this OK?

No it should still react like a new tab page and put the focus in the URL bar. I think this option should modify how about:newtab works to not render anything (return null) and not use about:blank.

I'm going to move it to 0.12.11.

[bsclifton]

Awesome- I think it makes sense pushing this back a release to make sure it's solid. We hashed out some ideas on Slack and it would be good not to rush it 😄

[luixxiul]

@bradleyrichter what is "My dashboard" there?

[bradleyrichter]

Dashboard is the new proposed name for the thing otherwise know as the new tab page.

On Nov 16, 2016, at 8:33 PM, Suguru Hirahara notifications@github.com wrote:

@bradleyrichter what is "My dashboard" there?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[bsclifton]

@bbondy ready for re-review 😄

Here's what the choice dropdown looks like:

Things to note:

• I updated the only occurrence of "homepage" to "home page" (see screenshot)
• Regardless of whether you pick Blank page or Dashboard, you go to about:newtab. This means the URL bar is focused
• new webdriver test created for blank about:newtab check

[bsclifton]

Rebased, resolved conflicts with tests, and made sure tests pass great 😄 Ready for re-review, @bbondy

Picture as proof that I'm not crazy 😄

[bbondy]

looks like app/extensions/brave/locales/en-US/preferences.properties has a conflict, could you rebase?

[bbondy]

Pls also run through automated if you don't mind, review of code looks good.

[bbondy]

++ thanks!

[bsclifton]

@bbondy thanks for checking this out and merging 😊