-
Notifications
You must be signed in to change notification settings - Fork 971
Conversation
Assuming this doesn't cause a problem without it on 0.12.9 I'm moving this to 0.12.10. |
I think this is missing the new images I committed yesterday? And the grey effect should be removed.
|
New pngs Commit number: 881b722
|
This needs rebasing pls |
@bbondy rebased! @bradleyrichter I see, I started on this ticket without knowing you needed to add some more assets. Is it looking right now? (see GIF above) |
@jkup It looks correct but now we can remove the dark filter in the CSS. Let's get it in master and then I can work with the hover state image if more visual change is needed. |
I like it! 🦁 |
@bradleyrichter @bsclifton I removed the dark filter but now I can hardly tell the difference between the two images. I updated the GIF in the description. Should we just go ahead and ship for now? |
@jkup perfect. Now I can modify the hover image and get it working perfectly through the magic of pixels. ; ) I'll merge it into master and I'll hot-fix the PNG file. |
git rebase -i
to squash commits (if needed).Fix #5528
Test Plan:
Hover over the Brave lion in the top right corner and make sure it looks like the GIF below.
@bradleyrichter this is what it looks like now. is this right?