This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Updating icons in URL bar
Fixes #5446
Fixes #4910
Auditors: @diracdeltas, @bbondy
Test Plan
Screenshots
HTTP shows yellow triangle now
![screen shot 2016-11-07 at 1 54 26 am](https://cloud.githubusercontent.com/assets/4733304/20052726/8a3a64ee-a492-11e6-9b93-70c79336c7fe.png)
Insecure/partially insecure modal uses triangle
![screen shot 2016-11-07 at 1 54 46 am](https://cloud.githubusercontent.com/assets/4733304/20052751/a3c237b6-a492-11e6-8264-34b4d46249de.png)
![screen shot 2016-11-07 at 1 53 38 am](https://cloud.githubusercontent.com/assets/4733304/20052754/a7d20be2-a492-11e6-9c29-2ce9fbf59487.png)
URL bar (when empty) now defaults to magnifying glass
![screen shot 2016-11-07 at 2 00 48 am](https://cloud.githubusercontent.com/assets/4733304/20052780/c5cc7c22-a492-11e6-9198-dd977b146c48.png)
when typing into URL bar, it shows magnifying glass instead of document
![screen shot 2016-11-07 at 1 55 02 am](https://cloud.githubusercontent.com/assets/4733304/20052804/d8945140-a492-11e6-9066-797aed8eaaee.png)