This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
[WiP] convert toolbar icons to svg #4890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #4855 Auditors: @bbondy Test Plan: 1. Open "about:autofill" 2. Click "Add Address" 3. The save button should be disabled 4. Enter the detail of form, the save button should be enabled 5. Remove all detail of form, the save button should be disabled 1. Open "about:autofill" 2. Click "Add Credit Card" 3. The save button should be disabled 4. Enter the detail of form, the save button should be enabled (Name, Card Number) 5. Remove all detail of form, the save button should be disabled (Name, Card Number) 1. Open "about:autofill" 2. Add address entry 3. Edit the address entry 4. Remove all detail of form, the save button should be disabled 1. Open "about:autofill" 2. Add credit card entry 3. Edit the credit card entry 4. Remove all detail of form, the save button should be disabled (Name, Card Number)
…arks - sortableTable now allows you to provide a control instead of a string for the header - about:bookmarks now properly sets tableID (not used yet) - Adding a new bookmark now requires either a title or location (URL). Required because clicking new bookmark creates an empty object (versus existing buttons which always supply the current page). - Fixed style issue with about:bookmarks (moved border-right on folderView to organizeView Fixes #4684 Fixes #4866 Auditors: @jkup, @bbondy Test Plan: 1. Launch Brave and visit about:bookmarks 2. Pick any folder on the left hand side and click it to select it 3. Click the +folder icon, above the folder view 4. Confirm that the new bookmark folder UI comes up and that it sets the parent folder properly 5. Click add and ensure folder gets added 6. Pick any folder and click it to select 7. In the "title" column, hit the star+ icon to add a new bookmark 8. Confirm you can't add an empty bookmark. Type and see the button enable itself. Delete chars and it disables itself again. 9. Confirm the parent folder is correct and type in a title/url. When done, hit save. 10. Confirm bookmark was added.
Auditors: @aekeus
Also fix crashes for URLs like `data:text/html,<script>alert\(1, 1\)</script>` and `data:text/html,<script>confirm\(1, 1\)</script>`
Disable save button when no detail present
"New bookmark folder" and "New bookmark" buttons added to about:bookmarks
Update localization
Allow about pages to reload and clone
UrlbarSuggestions does not work if you are offline
Start suggestions after first character not second fixes #3235
updated release notes for 0.12.5 RC6
Do not use default setting when value is false
Caption buttons are no longer tab focusable
fix #2105 requires brave/muon#73 Auditors: @bridiver, @bbondy
Auditors: @alexwykoff
Add whether brave is default browser check
Delete "defaultBrowserCheckComplete" only when check on startup is on
Split apart "always show bookmarks toolbar" and the bookmarks toolbar display mode
Improve UX of default browser check and Manage Adblock Setting button
Auditors: @bsclifton Fix #4120
Import favicon fix:
This reverts commit 878f7c5.
Fix #4913 Fix #4885 Auditors: @bbondy Test Plan: 1. go to homestarrunner.com and verify that the flash placeholder appears 2. go to http://web.mit.edu/zyan/Public/xframe.html and verify that the iframe is blank 3. open page devtools, load about:preferences, and verify in the Network tab that the `Access-Control-Allow-Origin` response header is not present on about-preferences.html
As of nodejs/node#7941, the node core punycode module is deprecated. Auditors: @bbondy Test Plan: n/a
BRAVE_IS_DEFAULT_BROWSER for test purpose fix #4958 Auditors: @bridiver, @bbondy Test Plan: 1. Make sure there is no session data 2. npm run start/test should not popup the check default browser modal and overrides brave as default browser. 3. BRAVE_IS_DEFAULT_BROWSER=true npm run start/test should not popup the check default browser modal and overrides brave as default browser. 4. BRAVE_IS_DEFAULT_BROWSER=false npm run start/test should popup the check default browser modal and overrides brave not be default browser.
default browser check should run only on release build
|
Shows 59 commits in the PR btw, I think something is messed |
|
@bbondy I closed and made a new one :( sorry I made a git boo boo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Auditors @bradleyrichter @bbondy
Fix #4852
Test Plan:
I wanted to get this in front of @bradleyrichter so we can iterate on the design and make sure the new logos look good. Also I need to wait for #4726 to merge so the startupButtons display issues are fixed.