Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disable View page source on chrome-extension pages #4819

Closed
wants to merge 9 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions js/contextMenus.js
Original file line number Diff line number Diff line change
Expand Up @@ -876,6 +876,7 @@ function mainTemplateInit (nodeProps, frame) {

const isLink = nodeProps.linkURL && nodeProps.linkURL !== ''
const isImage = nodeProps.mediaType === 'image'
const isExtensionPage = /^chrome-extension/.test(nodeProps.pageURL)
const isInputField = nodeProps.isEditable || nodeProps.inputFieldType !== 'none'
const isTextSelected = nodeProps.selectionText.length > 0

Expand Down Expand Up @@ -1017,15 +1018,21 @@ function mainTemplateInit (nodeProps, frame) {
focusedWindow.webContents.send(messages.SHORTCUT_ACTIVE_FRAME_FORWARD)
}
}
}, {
})

if (!isExtensionPage) {
template.push({
label: locale.translation('reloadPage'),
accelerator: 'CmdOrCtrl+R',
click: (item, focusedWindow) => {
if (focusedWindow) {
focusedWindow.webContents.send(messages.SHORTCUT_ACTIVE_FRAME_RELOAD)
}
}
},
})
}

template.push(
CommonMenu.separatorMenuItem,
addBookmarkMenuItem('bookmarkPage', siteUtil.getDetailFromFrame(frame, siteTags.BOOKMARK), false),
{
Expand All @@ -1051,11 +1058,10 @@ function mainTemplateInit (nodeProps, frame) {
// TODO: bravery menu goes here
)
}

template.push(CommonMenu.separatorMenuItem)
}

if (!isLink && !isImage) {
if (!isLink && !isImage && !isExtensionPage) {
template.push(CommonMenu.separatorMenuItem)
template.push({
label: locale.translation('viewPageSource'),
accelerator: 'CmdOrCtrl+Alt+U',
Expand All @@ -1068,15 +1074,17 @@ function mainTemplateInit (nodeProps, frame) {
}
}

template.push({
label: locale.translation('inspectElement'),
click: (item, focusedWindow) => {
webviewActions.inspectElement(nodeProps.x, nodeProps.y)
}
})
if (!isExtensionPage) {
template.push({
label: locale.translation('inspectElement'),
click: (item, focusedWindow) => {
webviewActions.inspectElement(nodeProps.x, nodeProps.y)
}
})
}

const passwordManager = getActivePasswordManager()
if (passwordManager.get('extensionId')) {
if (passwordManager.get('extensionId') && !isExtensionPage) {
template.push(
CommonMenu.separatorMenuItem,
{
Expand Down