Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Button icons are style-wonked #3937

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Button icons are style-wonked #3937

merged 1 commit into from
Sep 12, 2016

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Sep 12, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #3917

Test Plan:

Make sure that refresh and stop icons are correctly centered.

Ok, so what happened here was we turned the span.browserButton selector into just .browserButton so it could be used as a mixin (c63165f) but the problem is that then .browserButton conflicts with .fa and .fa is cancelling out the .browserButton line-height and font-size and some other things.

For a quick fix I just added back the element specific classes so it can still be used as a mixin but we should figure out a cleaner way to name classes / embed selectors so we don't have to hack around specificity.

Auditors @bradleyrichter @ayumi

@jkup jkup added this to the 0.12.1dev milestone Sep 12, 2016
@bradleyrichter
Copy link
Contributor

I confirmed it works in my local master repo. Thanks Jon!

@ayumi
Copy link
Contributor

ayumi commented Sep 12, 2016

++ 🚀

@jkup jkup merged commit 1294256 into master Sep 12, 2016
@jkup jkup deleted the button-styles-wonked branch September 13, 2016 05:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button icons are style-wonked. Must fix.
4 participants