This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Fix #3917
Test Plan:
Make sure that refresh and stop icons are correctly centered.
Ok, so what happened here was we turned the span.browserButton selector into just .browserButton so it could be used as a mixin (c63165f) but the problem is that then .browserButton conflicts with .fa and .fa is cancelling out the .browserButton line-height and font-size and some other things.
For a quick fix I just added back the element specific classes so it can still be used as a mixin but we should figure out a cleaner way to name classes / embed selectors so we don't have to hack around specificity.
Auditors @bradleyrichter @ayumi