This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
make use of ledger-geoid and the /v1/exchange/providers endpoint #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| countryCode: string, // ISO3166 2-letter code for country of browser's location | ||
| exchangeInfo: { // information about corresponding "friendliest" BTC exchange (suggestions welcome!) | ||
| titleText: string, // e.g., 'Create an account on ...' | ||
| buttonText: string, // e.g., 'Create' |
There was a problem hiding this comment.
as mentioned in review, please replace button and titletext with just exchangeName
There was a problem hiding this comment.
as mentioned in my reply: i don't think that's a good idea, but let's give it a shot and see what happens.
| if (exchangeInfo) ledgerInfo.exchangeURL = exchangeInfo.buttonURL | ||
| updateLedgerInfo() | ||
| ledgerInfo._internal.exchanges = body || {} | ||
| ledgerInfo.exchangeInfo = ledgerInfo._internal.exchanges[ledgerInfo.countryCode] |
There was a problem hiding this comment.
does this need a call to updateLedgerInfo?
|
thanks |
This was referenced Sep 14, 2016
|
Is QA needed? |
|
thanks for checking. no qa needed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auditor: @diracdeltas
test plan: nothing to be done until #3711 resolved
fixes #3824