This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
allow setting of user data dir #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacf22d to
2a6d5b8
Compare
| process.env.USER_DATA_DIR = path.join(app.getPath('appData'), app.getName() + '-' + process.env.NODE_ENV) | ||
| } | ||
|
|
||
| if (process.env.USER_DATA_DIR) { |
There was a problem hiding this comment.
Actually sorry, I think we should prefix this env var with BRAVE. There's a chance this will be defined on some people's machines already and cause problems.
use a different user data dir for each test run refactor autofill tests fixes #3618
2a6d5b8 to
3c1e03c
Compare
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits if needed.use a different user data dir for each test run
refactor autofill tests
fixes #3618