This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Extra polish for showing history on back/forward long press #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bsclifton
commented
Jul 27, 2016
- Back/Forward buttons now consider secondary actions (holding meta key, including honoring shift).
- History will attempt to load icons from appState if possible before defaulting favicon URL.
- Refactored getHistory method in Frame
- Organized unit test better; tried to write Frame unit tests but ran into complications 😦
…ey, including honoring shift). - History will attempt to load icons from appState if possible before defaulting favicon URL.
- removed jsdom-global from Spectron base file (brave.js), moved to a unit-test only file (braveUnit.js) - updated tests.md - added jsdom-global to ignoredPaths.js
|
I would like to see all of the title when |
| if (eventUtil.isForSecondaryAction(e)) { | ||
| windowActions.newFrame({ | ||
| location: url, | ||
| partitionNumber: activeFrame.props.frame.get('partitionNumber') |
There was a problem hiding this comment.
thanks for catching partition number too 👍
|
++ awesome |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.