Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Gray fa-unlock-alt in http mode #2160

Merged
merged 1 commit into from
Jun 13, 2016
Merged

Gray fa-unlock-alt in http mode #2160

merged 1 commit into from
Jun 13, 2016

Conversation

luixxiul
Copy link
Contributor

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

Related #1576

@bsclifton
Copy link
Member

bsclifton commented Jun 11, 2016

I love the idea of showing a different icon for HTTP... however, I personally think the icon is too close to the lock icon (some browsers show standard SSL as gray lock and EV SSL as green).

I'm curious what others would think about changing this to yellow or orange and then using a more obvious icon to represent HTTP. Something like:
fa-exclamation-triangle
fa-times-circle

or for comedy purposes:
fa-frown-o

@luixxiul
Copy link
Contributor Author

@bsclifton Thanks for the feedback. I thought about it too, but yellow or @BraveOrange should be reserved for worse scenarios until #1576 will be merged IMO.

@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Jun 11, 2016
@diracdeltas
Copy link
Member

I like how this makes HTTP and HTTPS look more different from each other, so +1. Agree that we should consider making HTTP look scarier as @bsclifton suggested.

@diracdeltas diracdeltas merged commit e81b95f into brave:master Jun 13, 2016
@luixxiul luixxiul added this to the 0.10.4dev milestone Jun 13, 2016
@luixxiul luixxiul deleted the urlbarIcon branch June 13, 2016 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants