This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add brave menu on windows #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, merging and will test on Windows now. |
| type: 'separator' | ||
| }, { | ||
| label: 'Bring All to Front', | ||
| role: 'front' |
There was a problem hiding this comment.
Doesn't seem to do anything, would prefer to just remove it unless there's an easy fix.
There was a problem hiding this comment.
Do you mean on Windows? It seems to work on OS X.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wondering if this fixes https://app.asana.com/0/search/71612189938994/78844679027346 and https://app.asana.com/0/search/71612189938994/78844679027343. i don't have a windows machine so screenshots would be useful.
Auditors: @bbondy