-
Notifications
You must be signed in to change notification settings - Fork 970
Conversation
Resolves brave#13972 Auditors: Test Plan:
a7e8802
to
b8aef8d
Compare
Codecov Report
@@ Coverage Diff @@
## master #13973 +/- ##
==========================================
- Coverage 56.55% 56.49% -0.07%
==========================================
Files 284 284
Lines 29280 29305 +25
Branches 4865 4869 +4
==========================================
- Hits 16559 16555 -4
- Misses 12721 12750 +29
|
Code looks good. ~~~I would change ledgerStatuses to just ledgerStatus unless we're returning multiple statuses. Other than that,~~~ I'm waiting for functionality testing. Was thinking that was a new file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the min-height
under the selector enabledContent__overlay
from 159px
to 188px
?
Due to the amount of content in the error overlay, it leaves an odd gap exposed at the bottom, compared to the corrupted wallet overlay, which fits the height of the underlying container with wallet information.
Compare:
With
Edit: This may not be an issue once the copy changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is a v.Next upcoming, I would say any cosmetic or convenience issues can be addressed then. @ryanml wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonrsadler sgtm, approved
@jasonrsadler since this will go to 0.22.x release 3, don't forget to merge it to: |
Resolves #13972
New look:

Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests