This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
do not store sites cache as a bookmark cache #12919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- instead of sitekey
6e607ef to
e784811
Compare
Codecov Report
@@ Coverage Diff @@
## master #12919 +/- ##
==========================================
+ Coverage 56.12% 56.12% +<.01%
==========================================
Files 279 279
Lines 27321 27321
Branches 4443 4442 -1
==========================================
+ Hits 15334 15335 +1
+ Misses 11987 11986 -1
|
bbondy
approved these changes
Jan 30, 2018
bbondy
added a commit
that referenced
this pull request
Jan 30, 2018
do not store sites cache as a bookmark cache
bbondy
added a commit
that referenced
this pull request
Jan 30, 2018
do not store sites cache as a bookmark cache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 6e607ef we also changed cache location to use actual url instead of site key (no-qa-needed for this -- please test just the below).
Fix #12903
Test Plan: