Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Border radius on URLs #12897

Merged
merged 4 commits into from
Feb 8, 2018
Merged

Conversation

arsalankhalid
Copy link
Contributor

@arsalankhalid arsalankhalid commented Jan 29, 2018

Fixes #10692

Reviewer: @bsclifton

Thoughts: I first tried going to the JS styles, as the docs identified that brave will be styled via js, and less is legacy, but I couldn't find that to fix the border-radius issue. Instead, i went to navigationBar.less and made the values arbitrary at 0, which seems to have fixed it. Please advise if too hacky, just trying to get my hands dirty and learn more, a great exercise all round.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test plan

See #10692

@luixxiul luixxiul added design A design change, especially one which needs input from the design team. feature/URLbar labels Jan 29, 2018
@petemill petemill self-requested a review January 30, 2018 00:27
@arsalankhalid
Copy link
Contributor Author

@bsclifton any thoughts on this, when you get the chance? :)

@bsclifton bsclifton added this to the 0.23.x (Nightly Channel) milestone Feb 8, 2018
@bsclifton bsclifton self-requested a review February 8, 2018 16:57
@bsclifton bsclifton requested a review from luixxiul February 8, 2018 19:37
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I tried a lot of scenarios (wide URL bar, title bar always shows, etc) and verified it always shows as expected.

Great work! 😄 And thanks for your first contribution 🎉

@bsclifton bsclifton merged commit 3a81d2c into brave:master Feb 8, 2018
@bsclifton
Copy link
Member

screen shot 2018-02-08 at 1 22 24 pm

@arsalankhalid
Copy link
Contributor Author

Awesome, just noticed that it got merged - thank you @bsclifton :)

@arsalankhalid arsalankhalid deleted the borderRadiusOnURLs branch March 11, 2018 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/URLbar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Torrent viewer URL bar has border radius
4 participants