Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

enforce max limit to ev cert display #12781

Merged
merged 1 commit into from
Jan 22, 2018
Merged

enforce max limit to ev cert display #12781

merged 1 commit into from
Jan 22, 2018

Conversation

cezaraugusto
Copy link
Contributor

follow-up of #11776
fix #12780

screen shot 2018-01-22 at 7 22 06 pm

Also there's should be a "tooltip" with the full cert name when you hover

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 5915913 into master Jan 22, 2018
@cezaraugusto cezaraugusto deleted the ev_cert_max_limit branch January 22, 2018 23:28
cezaraugusto added a commit that referenced this pull request Jan 22, 2018
enforce max limit to ev cert display
@cezaraugusto
Copy link
Contributor Author

master 5915913
0.21.x 347b82f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EV certificate string overflows
3 participants