Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add shortcut for toggling the bookmark toolbar #12625

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

jbyte
Copy link
Contributor

@jbyte jbyte commented Jan 12, 2018

Resolves #12594

Auditors:

Test Plan:

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@codecov-io
Copy link

codecov-io commented Jan 12, 2018

Codecov Report

Merging #12625 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12625      +/-   ##
==========================================
- Coverage   56.24%    56.2%   -0.04%     
==========================================
  Files         278      278              
  Lines       27115    27115              
  Branches     4392     4392              
==========================================
- Hits        15250    15241       -9     
- Misses      11865    11874       +9
Flag Coverage Δ
#unittest 56.2% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
app/common/commonMenu.js 52.2% <ø> (ø) ⬆️
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 27.25% <0%> (-0.31%) ⬇️

@bsclifton bsclifton added this to the 0.22.x (Nightly Channel) milestone Jan 12, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly! Super nice addition 😄 👍

@bsclifton
Copy link
Member

@jonathansampson would you be able to give this a go on Windows?

@jonathansampson
Copy link
Collaborator

@bsclifton Checking it out now!

Copy link
Collaborator

@jonathansampson jonathansampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Works as expected!

@jonathansampson jonathansampson merged commit 077c357 into brave:master Jan 12, 2018
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants