This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Check nullity of webcontents and empty url from getURL() #12555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12508 is caused by empty
url which will leads to sending {cancel: true} to callback of
session.webRequest.onBeforeRequest
and download process will beaborted.
Also verified this won't break the issues which
#12256 fixes
fix #12508
Auditors: @bridiver, @diracdeltas, @bsclifton
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests