This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Issue 12304: Updating UPDATE_HOST to point to brave.com cname #12305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12305 +/- ##
=======================================
Coverage 55.29% 55.29%
=======================================
Files 276 276
Lines 26740 26740
Branches 4310 4310
=======================================
Hits 14786 14786
Misses 11954 11954
|
diracdeltas
reviewed
Dec 16, 2017
js/constants/appConfig.js
Outdated
| @@ -5,8 +5,8 @@ const Immutable = require('immutable') | |||
| const {getTargetAboutUrl} = require('../lib/appUrlUtil') | |||
|
|
|||
| // BRAVE_UPDATE_HOST should be set to the host name for the auto-updater server | |||
| const updateHost = process.env.BRAVE_UPDATE_HOST || 'https://brave-laptop-updates.global.ssl.fastly.net' | |||
| const winUpdateHost = process.env.BRAVE_WIN_UPDATE_HOST || 'https://brave-download.global.ssl.fastly.net' | |||
| const updateHost = process.env.BRAVE_UPDATE_HOST || 'https://laptop-updates.brave.com/' | |||
b1a4560 to
17632a4
Compare
|
this looks good to me but i will defer to @aekeus to confirm that these host cnames are stable for production |
|
There is a current requirement to pass through Fastly for log file geolocation. This will break that process unless I am misunderstanding. |
|
Filed #12320 to investigate alternate ways to collect logs. |
aekeus
previously approved these changes
Dec 19, 2017
17632a4 to
d621440
Compare
diracdeltas
approved these changes
Dec 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12304
Testing Notes: Geo logs for brave stats are captured using fastly. After this change download and update requests will go through brave domains which should go through fastly.net. Verify if
statsis working correctly.