This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 971
Migrates the contribution amounts from old USD setting to new BAT setting #11722
Merged
NejcZdovc
merged 1 commit into
brave:master
from
bsclifton:contribution-amount-migration
Oct 31, 2017
Merged
Migrates the contribution amounts from old USD setting to new BAT setting #11722
NejcZdovc
merged 1 commit into
brave:master
from
bsclifton:contribution-amount-migration
Oct 31, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting Fixes #11719 Auditors: @NejcZdovc, @evq, @petemill Test Plan: - Use an older version of Brave (0.18.36 for example) - Enable payments and set contribution amount as one of the original amounts (like $10 for example) - Run a build with this fix in it - In preferences#payments, you should notice it should be 25 BAT if USD was $5, 50 if $10, 75 if $15, 100 if $20 - Exit Brave - Open the ledger-state.json file and inspect, looking for properties.fee.amount - This should have the new value (25, 50, 75, or 100) not the old value (5, 10, 15, 20)
Codecov Report
@@ Coverage Diff @@
## master #11722 +/- ##
=========================================
+ Coverage 52.01% 52.12% +0.1%
=========================================
Files 269 269
Lines 25534 25553 +19
Branches 4069 4074 +5
=========================================
+ Hits 13282 13319 +37
+ Misses 12252 12234 -18
|
8 tasks
NejcZdovc
approved these changes
Oct 31, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ looks good to me
NejcZdovc
added a commit
that referenced
this pull request
Oct 31, 2017
Migrates the contribution amounts from old USD setting to new BAT setting
NejcZdovc
added a commit
that referenced
this pull request
Oct 31, 2017
Migrates the contribution amounts from old USD setting to new BAT setting
NejcZdovc
added a commit
that referenced
this pull request
Oct 31, 2017
Migrates the contribution amounts from old USD setting to new BAT setting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11719
Auditors: @NejcZdovc, @evq, @petemill
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests