Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix button alignment on error page #11008

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Fix button alignment on error page #11008

merged 1 commit into from
Sep 19, 2017

Conversation

srirambv
Copy link
Collaborator

Submitter Checklist:
Fixes:#11007

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:
Visit https://expired.badssl.com/
Reduce the browser width to 478px
Ensure buttons are aligned properly as shown
image

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay looks way better, thanks sir!

@cezaraugusto cezaraugusto merged commit 795f36a into brave:master Sep 19, 2017
cezaraugusto added a commit that referenced this pull request Sep 19, 2017
Fix button alignment on error page
cezaraugusto added a commit that referenced this pull request Sep 19, 2017
Fix button alignment on error page
@cezaraugusto
Copy link
Contributor

per branch sha:

master 795f36a
0.20.x 1207731
0.19.x 03e000f

@@ -12,7 +12,7 @@ body {

.errorContent {
display: flex;
width: 40vw;
width: 60vw;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi this change affects every error page so let's not forget to do QA for the pages as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants