Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Sort properties file and remove duplicates #10647

Merged
merged 2 commits into from
Sep 4, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/extensions/brave/about-contributions.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<link rel="localization" href="locales/{locale}/preferences.properties">
<link rel="localization" href="locales/{locale}/common.properties">
<link rel="localization" href="locales/{locale}/bravery.properties">
<link rel="localization" href="locales/{locale}/error.properties">
<link rel="localization" href="locales/{locale}/errorMessages.properties">
</head>
<body>
Expand Down
1 change: 0 additions & 1 deletion app/extensions/brave/about-error.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<script src="ext/l20n.min.js"></script>
<script src="gen/aboutPages.entry.js" async></script>
<link rel="localization" href="locales/{locale}/app.properties">
<link rel="localization" href="locales/{locale}/error.properties">
<link rel="localization" href="locales/{locale}/errorMessages.properties">
</head>
<body>
Expand Down
1 change: 0 additions & 1 deletion app/extensions/brave/about-preferences.html
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<link rel="localization" href="locales/{locale}/preferences.properties">
<link rel="localization" href="locales/{locale}/common.properties">
<link rel="localization" href="locales/{locale}/bravery.properties">
<link rel="localization" href="locales/{locale}/error.properties">
<link rel="localization" href="locales/{locale}/errorMessages.properties">
<link rel="localization" href="locales/{locale}/extensions.properties">
</head>
Expand Down
13 changes: 7 additions & 6 deletions app/extensions/brave/locales/en-US/adblock.properties
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
adblockTitle=Ad Block
adblock=Ad Block
lastUpdateCheckDateLabel=Last update check:
lastCheckETagLabel=Last check ETag:
blockedCountLabel=Blocked count:
adblockTitle=Ad Block
adblockTooManyListsWarning=Warning: Turning on too many lists will degrade performance
additionalFilterLists=Additional filter lists
customFilters=Custom filters
blockedCountLabel=Blocked count:
customFilterDescription=One per line, a filter is described in Adblock Plus filter syntax
adblockTooManyListsWarning=Warning: Turning on too many lists will degrade performance
customFilters=Custom filters
disableAdBlockForSite=Disable Ad block
lastCheckETagLabel=Last check ETag:
lastUpdateCheckDateLabel=Last update check:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srirambv I mean like this:

label_lastUpdateCheckDate=...
label_lastCheckETag=...

Specifying a hierarchy with dashes or something more proper would make it easier for us to see the system of the localization strings and enhance it when new ones get added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luixxiul I'd suggest creating a new issue and proposing the strategy. If it's something that is easier for translators and also for programmers, then maybe we can adapt it. Personally, I don't know how helpful it would be

Loading