Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add findx as a Search Provider #10520

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Add findx as a Search Provider #10520

merged 1 commit into from
Aug 16, 2017

Conversation

kjozwiak
Copy link
Member

Fix #10432

Auditors: @bbondy

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@kjozwiak kjozwiak added this to the 0.21.x (Nightly Channel) milestone Aug 16, 2017
@kjozwiak kjozwiak requested a review from bbondy August 16, 2017 04:30
@bbondy
Copy link
Member

bbondy commented Aug 16, 2017

Awesome, thanks! Great job on your first PR.

@bbondy bbondy merged commit 8bd6d51 into master Aug 16, 2017
@luixxiul luixxiul deleted the findx branch August 16, 2017 04:36
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants