Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow creating directories for downloads path #10481

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Allow creating directories for downloads path #10481

merged 1 commit into from
Aug 15, 2017

Conversation

cndouglas
Copy link

@cndouglas cndouglas commented Aug 14, 2017

Fixes #10479

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Note: macOS-only

  1. Open about:preferences > General tab.
  2. Under "Save my downloads here:", click the path field or the pencil icon.
  3. Make sure there is a "New Folder" button at the bottom left (see screenshot).

image

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@cndouglas cndouglas added this to the 0.21.x (Nightly Channel) milestone Aug 14, 2017
@cndouglas cndouglas self-assigned this Aug 14, 2017
@cndouglas cndouglas requested a review from bsclifton August 14, 2017 23:05
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thank you, works like a charm 😃

@NejcZdovc NejcZdovc merged commit 1ff30e7 into brave:master Aug 15, 2017
@bsclifton
Copy link
Member

❤️

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this pull request Aug 15, 2017
NejcZdovc added a commit that referenced this pull request Aug 15, 2017
Fixes failing unit test that was introduced with #10481
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this pull request Aug 18, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants