This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes window restore and fullscreen #10458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10458 +/- ##
==========================================
- Coverage 54.54% 54.17% -0.37%
==========================================
Files 245 246 +1
Lines 21156 21374 +218
Branches 3263 3316 +53
==========================================
+ Hits 11539 11579 +40
- Misses 9617 9795 +178
|
deffe88 to
0a18ce6
Compare
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Aug 14, 2017
Pre-work for brave#10458 tests Auditors: @bbondy @bsclifton Test Plan: - covered by automated tests
8 tasks
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Aug 14, 2017
Pre-work for brave#10458 tests Auditors: @bbondy @bsclifton Test Plan: - covered by automated tests
0a18ce6 to
b9a3a8b
Compare
|
I'm wondering if this could be merged to 0.21 to do enough QA over releases among various environments |
|
This is targeted for 0.20, so we should keep it here |
|
This PR is complete, I am just writing some tests |
73f9437 to
f7feadb
Compare
f7feadb to
41473e9
Compare
This was referenced Aug 18, 2017
Closed
|
I just did some manual testing- it seems all issues are resolved except for #3754 It always centers the window 🤔 |
bsclifton
suggested changes
Aug 23, 2017
|
@bsclifton #3754 should be fixed now as well. Can you please re-test? |
4ff2c50 to
aad4a9a
Compare
Resolves brave#3754 Resolves brave#6602 Resolves brave#8600 Resolves brave#8925 Resolves brave#9709 Auditors: Test Plan:
aad4a9a to
921c203
Compare
|
Webdriver test for #3754 added |
This was causing a crash which breaks the browser window. I believe this issue is related to the issues we have where wrong index is picked after closing / tearing off tab Auditors: @NejcZdovc, @bbondy
bsclifton
approved these changes
Aug 28, 2017
There was a problem hiding this comment.
I confirmed each issue is working as expected 😄 Great job on this
FYI - I ran into an issue while testing which I think is unrelated to this PR and submitted a patch which prevents the window from crashing (I think the root cause will be fixed when @bbondy finishes up the tab index PR)
|
I went through all 5 issues and added steps / fixed the labels 😄 Should be good to go! Merging 👍 |
NejcZdovc
pushed a commit
that referenced
this pull request
Aug 28, 2017
Fixes window restore and fullscreen
Closed
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't squash commits
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #3558
Resolves #3754
Resolves #6602
Resolves #8600
Resolves #8925
Resolves #9371
Resolves #9709
Test Plan:
Reviewer Checklist:
Tests