Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

immutableData.getIn first arg should be an array #10417

Merged
merged 1 commit into from
Aug 10, 2017
Merged

immutableData.getIn first arg should be an array #10417

merged 1 commit into from
Aug 10, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 10, 2017

Fix #10415

Auditors: @bsclifton

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
    No but it's kind of a lame introduced bug that is not likely to happen again now that we're on immutable.
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy self-assigned this Aug 10, 2017
@bbondy bbondy added this to the 0.18.x Hotfix milestone Aug 10, 2017
@bsclifton bsclifton self-requested a review August 10, 2017 21:19
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Would be hard to test

I scanned for other possible immutable issues- the only one I found was this (cc: @NejcZdovc)

.set(['bookmarkFolders'], Immutable.fromJS({

(this should be using like .set('key') or .setIn(['key']))

@bsclifton bsclifton merged commit f1c4ed2 into master Aug 10, 2017
@bsclifton bsclifton deleted the 10415 branch August 10, 2017 21:33
bsclifton added a commit that referenced this pull request Aug 10, 2017
immutableData.getIn first arg should be an array
bsclifton added a commit that referenced this pull request Aug 10, 2017
immutableData.getIn first arg should be an array
bsclifton added a commit that referenced this pull request Aug 10, 2017
immutableData.getIn first arg should be an array
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants