This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 971
Add rel='noopener' to all external links #10290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm.. I'll take a look at the failing tests. |
@voldemortensen there are some failing tests and you don't have to try to fix them unless you introduced new ones with your PR. |
Adding @darkdh for review too 😄 |
diracdeltas
approved these changes
Aug 7, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for submitting this!
My pleasure! I'll definitely be contributing more. I love the ideas around this browser. |
To avoid tab-nabbing attacks, all external links with target='_blank' must have rel='noopener' Fix #9743
Awesome, thanks for the contribution @voldemortensen! 😄 As a follow up, would you be able to add some QA steps (ex: which screens to visit)? |
Absolutely |
QA steps: Visit a new tab
Visit the torrent viewer page
Visit the about Brave page
Visit the Sync page
Visit the Payments tab
Activate payments
Visit Bitcoin page
(I think I got everything) |
@voldemortensen perfect! thanks for the steps :-) |
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid tab-nabbing attacks, all external links with
target='_blank' must have rel='noopener'
Fix #9743
Submitter Checklist:
git rebase -i
to squash commits (if needed).(I couldn't find a list of people to tag, although I did read the pull request process page.)
Test Plan:
See #10290 (comment)
Reviewer Checklist:
Tests