Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Moves hrefPreview from Frame #10282

Merged
merged 1 commit into from
Aug 5, 2017
Merged

Moves hrefPreview from Frame #10282

merged 1 commit into from
Aug 5, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 3, 2017 •
edited
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #10194

Auditors: @bsclifton

Test Plan:

  • check if hover preview is working for links

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added the perf label Aug 3, 2017
@NejcZdovc NejcZdovc added this to the 0.19.x (Beta Channel) milestone Aug 3, 2017
@NejcZdovc NejcZdovc self-assigned this Aug 3, 2017
@NejcZdovc NejcZdovc requested a review from bsclifton August 3, 2017 21:37
@NejcZdovc
Moves hrePreview from Frame
dad3f11 
Resolves brave#10194

Auditors: @bsclifton

Test Plan:
@NejcZdovc NejcZdovc force-pushed the hotfix/#10194-hrefpreview branch from b181999 to dad3f11 Compare August 3, 2017 21:40
@NejcZdovc NejcZdovc requested a review from bridiver August 4, 2017 17:10
bridiver
bridiver approved these changes Aug 5, 2017
View reviewed changes
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit c91b1c9 into brave:master Aug 5, 2017
@bridiver bridiver mentioned this pull request Aug 5, 2017
Closed
bsclifton
bsclifton reviewed Aug 7, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton left review comments

@bridiver bridiver bridiver approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
perf
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @bridiver @bsclifton