Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Playing media on a site adds it to the autoplay site permission list (even when defaulted to "always allow") #9008

Closed
srirambv opened this issue May 23, 2017 · 2 comments · Fixed by #10178
Closed

Playing media on a site adds it to the autoplay site permission list (even when defaulted to "always allow") #9008

srirambv opened this issue May 23, 2017 · 2 comments · Fixed by #10178
Assignees
@darkdh
Labels
bug feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x Hotfix 11 ...

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 23, 2017 •
edited by bsclifton
Loading

Test plan

  1. Clean install Brave
  2. Ensure the default autoplay media is set to always allow
  3. Visit any site and play audio/video
  4. Verify site is NOT added to the site permission list as allow (Preferences > Security)

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Playing media on a site adds it to the site permission list even with default permission is set to always allow

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.15.306
    rev 0067c4f
    Muon 3.0.200

  • Steps to reproduce:

    1. Clean install 0.15.306
    2. Ensure the default autoplay media is set to always allow
    3. Visit any site and play audio/video, site gets added to the site permission list as allow

  • Actual result:
    Playing media on a site adds it to the site permission list even with default permission is set to always allow

  • Expected result:
    Should only add when permission is set different from the default setting

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    Marking as 0.16.100 as its not a release blocker. Please pull it back to 0.15.3xx if requried
@srirambv srirambv added this to the 0.16.100 milestone May 23, 2017
@alexwykoff alexwykoff removed this from the 0.16.100 milestone May 23, 2017
darkdh added a commit that referenced this issue Jul 27, 2017
@darkdh
Autoplay refactoring
a0b5d9d 
fixes #9143
fixes #9008
fixes #9171

Auditors: @bsclifton, @bridiver, @cezaraugusto

Test Plan:
Covered by automatic test

Specific STR for #9171:
1. Turn on autoplay to `always ask` and make sure there is no any allow
autoplay permissions
2. Go to https://youtu.be/g_6yBZKj-eo and don't click on notification
bar
3. Open another tab and go to
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay
and still don't click on notification bar
4. Go back the youtube tab you will find out the notification bar is non
clickable
5. Go to the w3schools tab and it will also be non clickable
@darkdh darkdh mentioned this issue Jul 27, 2017
Merged
8 tasks
@darkdh darkdh added this to the 0.20.x (Nightly Channel) milestone Jul 27, 2017
@bsclifton bsclifton changed the title Playing media on a site adds it to the site permission list even with default permission is set to always allow Playing media on a site adds it to the autoplay site permission list (even when defaulted to "always allow") Jul 30, 2017
darkdh added a commit that referenced this issue Jul 31, 2017
@darkdh
Autoplay refactoring
1a49ab8 
fixes #9143
fixes #9008
fixes #9171

Auditors: @bsclifton, @bridiver, @cezaraugusto

Test Plan:
Covered by automatic test

Specific STR for #9171:
1. Turn on autoplay to `always ask` and make sure there is no any allow
autoplay permissions
2. Go to https://youtu.be/g_6yBZKj-eo and don't click on notification
bar
3. Open another tab and go to
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay
and still don't click on notification bar
4. Go back the youtube tab you will find out the notification bar is non
clickable
5. Go to the w3schools tab and it will also be non clickable
@bsclifton bsclifton mentioned this issue Aug 18, 2017
Closed
This was referenced Dec 20, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Dec 28, 2017
Closed
@darkdh darkdh modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 11 (Release Channel) Jan 4, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2018

Clearing flags as this was tested against 0.20.x, needs to be re-tested against 0.19.x.

@srirambv
Copy link
Collaborator Author

srirambv commented Jan 5, 2018

Verified on 0.19.126. No site setting added when setting is set to Always allow

This was referenced Jan 5, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 9, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/autoplay QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x Hotfix 11 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Autoplay refactoring brave/browser-laptop
7 participants
@alexwykoff @kjozwiak @luixxiul @bsclifton @darkdh @srirambv @LaurenWags