Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Feature Request: Default Private Browsing / Private Tab Sessions #8963

Closed
ghost opened this issue May 19, 2017 · 0 comments
Closed

Feature Request: Default Private Browsing / Private Tab Sessions #8963

ghost opened this issue May 19, 2017 · 0 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/private-tabs privacy settings shell-integration Integrating brave with OS-level UI features. stale

Comments

@ghost
Copy link

ghost commented May 19, 2017

Did you search for similar issues before submitting this one?

Describe the issue you encountered:

  • Links opened from other apps and the desktop open in nonprivate session in Brave. This may unintentionally expose data/metadata to third party services on the page attempting to profile the user, particularly when those third party services have not yet been identified by Brave or its components. Browsing data added to the nonprivate session by this type of event is also retained until the nonprivate session data (using this as an all inclusive reference to history, cache, cookies, etc,) is deleted, even with the strictest privacy and security settings, making it difficult to visit a link shared elsewhere without contaminating or exposing existing browsing data by implicit consent.

The following options (and the behaviors described) added to the security tab can prevent this:

  • Start Brave in Private Mode - When enabled, Brave will open in Private mode by default. Data from Private tabs is deleted when the browser closes and not shared with the data from a non-private session.
  • Private Tab Sessions - Browsing data from a Private tab is not shared with other private tabs.

Additionally, useful context menu integration from the desktop/win explorer:

  • Open link in Brave
  • Open link in Brave (Private)

Platform and Version information from about:brave

Brave 0.15.2
rev af7ef42
Muon 2.58.9
libchromiumcontent 58.0.3029.96
V8 5.8.283.37
Node.js 7.9.0
Update Channel dev
os.platform win32
os.release 10.0.14393
os.arch x64

  • Steps to reproduce:

    1. Open hyperlink from a desktop shortcut, or any other app which does not feature its own web browsing capability
  • Expected result:

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:

    1. During testing, check that searches from private tabs/windows aren't contributing to search functionality in fresh windows/tabs and do not persist when Brave is restarted. May require altering really old behavior, so checking for other bugs generated by your fixes is prudent.
  • Related information:
    Included context menu suggestion because implementing those first could make most of these features a quick win. Private Tab Sessions may require much more technical involvement.

@bsclifton bsclifton added privacy shell-integration Integrating brave with OS-level UI features. settings labels May 19, 2017
diracdeltas added a commit that referenced this issue Sep 7, 2017
partial fix for #6684
and #8963

TODO: Either the private tab sessions should be cleared and revert back to private session 1 when the last private tab is closed, or we need a private tab session manager menu. Currently the session will keep incrementing until the browser restarts.

Test Plan:
1. open private tab
2. in the private tab, go to a site that requires login
3. login, then open a link from that site in a new private tab
4. you should also be logged in in the second private tab
5. open a new private tab
6. go to the same site. you should not be logged in.
diracdeltas added a commit that referenced this issue Sep 7, 2017
partial fix for #6684
and #8963

TODO: Either the private tab sessions should be cleared and revert back to private session 1 when the last private tab is closed, or we need a private tab session manager menu. Currently the session will keep incrementing until the browser restarts.

Test Plan:
1. open private tab
2. in the private tab, go to a site that requires login
3. login, then open a link from that site in a new private tab
4. you should also be logged in in the second private tab
5. open a new private tab
6. go to the same site. you should not be logged in.
diracdeltas added a commit that referenced this issue Sep 11, 2017
partial fix for #6684
and #8963

TODO: Either the private tab sessions should be cleared and revert back to private session 1 when the last private tab is closed, or we need a private tab session manager menu. Currently the session will keep incrementing until the browser restarts.

Test Plan:
1. open private tab
2. in the private tab, go to a site that requires login
3. login, then open a link from that site in a new private tab
4. you should also be logged in in the second private tab
5. open a new private tab
6. go to the same site. you should not be logged in.
diracdeltas added a commit that referenced this issue Oct 11, 2017
partial fix for #6684
and #8963

TODO: Either the private tab sessions should be cleared and revert back to private session 1 when the last private tab is closed, or we need a private tab session manager menu. Currently the session will keep incrementing until the browser restarts.

Test Plan:
1. open private tab
2. in the private tab, go to a site that requires login
3. login, then open a link from that site in a new private tab
4. you should also be logged in in the second private tab
5. open a new private tab
6. go to the same site. you should not be logged in.
diracdeltas added a commit that referenced this issue Oct 25, 2017
partial fix for #6684
and #8963

TODO: Either the private tab sessions should be cleared and revert back to private session 1 when the last private tab is closed, or we need a private tab session manager menu. Currently the session will keep incrementing until the browser restarts.

Test Plan:
1. open private tab
2. in the private tab, go to a site that requires login
3. login, then open a link from that site in a new private tab
4. you should also be logged in in the second private tab
5. open a new private tab
6. go to the same site. you should not be logged in.
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
diracdeltas added a commit that referenced this issue Dec 4, 2017
partial fix for #6684
and #8963

TODO: Either the private tab sessions should be cleared and revert back to private session 1 when the last private tab is closed, or we need a private tab session manager menu. Currently the session will keep incrementing until the browser restarts.

Test Plan:
1. open private tab
2. in the private tab, go to a site that requires login
3. login, then open a link from that site in a new private tab
4. you should also be logged in in the second private tab
5. open a new private tab
6. go to the same site. you should not be logged in.
diracdeltas added a commit that referenced this issue Jan 2, 2018
partial fix for #6684
and #8963

TODO: Either the private tab sessions should be cleared and revert back to private session 1 when the last private tab is closed, or we need a private tab session manager menu. Currently the session will keep incrementing until the browser restarts.

Test Plan:
1. open private tab
2. in the private tab, go to a site that requires login
3. login, then open a link from that site in a new private tab
4. you should also be logged in in the second private tab
5. open a new private tab
6. go to the same site. you should not be logged in.
@bsclifton bsclifton added stale addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. labels Sep 10, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/private-tabs privacy settings shell-integration Integrating brave with OS-level UI features. stale
Projects
None yet
Development

No branches or pull requests

2 participants