Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

home button is broken in 0.15.303 #8845

Closed
diracdeltas opened this issue May 12, 2017 · 0 comments
Closed

home button is broken in 0.15.303 #8845

diracdeltas opened this issue May 12, 2017 · 0 comments
Assignees
@bsclifton
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@diracdeltas
Copy link
Member

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    when 'show home button' is enabled in prefs, clicking the home button does nothing

Brave: 0.15.303
rev: 04ceba3
Muon: 3.0.100
libchromiumcontent: 58.0.3029.96
V8: 5.8.283.37
Node.js: 7.9.0
Update Channel: dev
os.platform: darwin
os.release: 15.6.0
os.arch: x64
@diracdeltas diracdeltas added this to the 0.15.300 milestone May 12, 2017
@luixxiul luixxiul added the bug label May 12, 2017
@bsclifton bsclifton self-assigned this May 12, 2017
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned bsclifton May 12, 2017
@NejcZdovc NejcZdovc assigned bsclifton and unassigned NejcZdovc May 12, 2017
bsclifton added a commit that referenced this issue May 12, 2017
@bsclifton
Fix home button
e2f45bc 
Add property that was missed during conversion to redux component (with 174f086)

Fixes #8845

Auditors: @bridiver
This was referenced May 23, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
6 participants
@diracdeltas @alexwykoff @luixxiul @bsclifton @NejcZdovc @srirambv